linux-kernel - [PATCH] usb: usbip: fix odd_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2102191807040.21109@hadrien>
Date:   Fri, 19 Feb 2021 18:10:10 +0100 (CET)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
cc:     Valentina Manea <valentina.manea.m@...il.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...ts.01.org
Subject: [PATCH] usb: usbip: fix odd_ptr_err.cocci warnings

From: kernel test robot <lkp@...el.com>

PTR_ERR should access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>
---

tree:   https://github.com/0day-ci/linux/commits/UPDATE-20210219-175233/Tetsuo-Handa/usb-usbip-serialize-attach-detach-operations/20210219-083847
head:   32963105fe23b600644ac10f0f9a42124a289990
commit: 32963105fe23b600644ac10f0f9a42124a289990 usb: usbip: serialize attach/detach operations
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

The above link doesn't work for me, so I don't know whether the goto label
is correct.

 usbip_common.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/usbip/usbip_common.c
+++ b/drivers/usb/usbip/usbip_common.c
@@ -775,7 +775,7 @@ int usbip_prepare_threads(struct usbip_t
 	}
 	tx = kthread_create(tx_fn, ud, tx_name);
 	if (IS_ERR(tx)) {
-		err = PTR_ERR(rx);
+		err = PTR_ERR(tx);
 		goto out_rx;
 	}
 	uti->tcp_socket = socket;