linux-kernel - Re: [PATCH net-next RFC v4] net: hdlc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210219103948.6644e61f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 19 Feb 2021 10:39:48 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xie He <xie.he.0141@...il.com>
Cc:     Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Linux X25 <linux-x25@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Martin Schiller <ms@....tdt.de>,
        Krzysztof Halasa <khc@...waw.pl>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB
 frames

On Thu, 18 Feb 2021 12:23:28 -0800 Xie He wrote:
> On Thu, Feb 18, 2021 at 12:06 PM Xie He <xie.he.0141@...il.com> wrote:
> >
> > On Thu, Feb 18, 2021 at 11:55 AM Leon Romanovsky <leon@...nel.org> wrote:  
> > >
> > > This is how we write code, we use defines instead of constant numbers,
> > > comments to describe tricky parts and assign already preprocessed result.
> > >
> > > There is nothing I can do If you don't like or don't want to use Linux kernel
> > > style.  
> >
> > So what is your suggestion exactly? Use defines or write comments?
> >
> > As I understand, you want to replace the "3 - 1" with "2", and then
> > write comments to explain that this "2" is the result of "3 - 1".
> >
> > Why do you want to do this? You are doing useless things and you force
> > readers of this code to think about useless things.
> >
> > You said this was "Linux kernel style"? Why? Which sentence of the
> > Linux kernel style guide suggests your way is better than my way?  
> 
> Nevermind, if you *really* want me to replace this "3 - 1" with "2"
> and explain in the comment that the "2" is a result of "3 - 1". I'll
> do this. I admit this is a style issue. So it is hard to argue and
> reach an agreement. Just reply with a request and I'll make the
> change. However I'm not able to agree with you in my heart.

Not entirely sure what the argument is about but adding constants would
certainly help.

More fundamentally IDK if we can make such a fundamental change here.
When users upgrade from older kernel are all their scripts going to
work the same? Won't they have to bring the new netdev up?