linux-kernel - Re: [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDANkjYEMJtt9SGu@google.com>
Date:   Fri, 19 Feb 2021 11:12:18 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     "Life is hard, and then you die" <ronald@...ovation.ch>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Sergiu Cuciurean <sergiu.cuciurean@...log.com>,
        Lee Jones <lee.jones@...aro.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Input: applespi: Don't wait for responses to
 commands indefinitely.

On Wed, Feb 17, 2021 at 12:45:51PM -0800, Life is hard, and then you die wrote:
> 
>   Hi Dmitry,
> 
> On Wed, Feb 17, 2021 at 12:23:23PM -0800, Dmitry Torokhov wrote:
> > 
> > On Wed, Feb 17, 2021 at 11:07:16AM -0800, Ronald Tschalär wrote:
> > > @@ -869,7 +878,7 @@ static int applespi_send_cmd_msg(struct applespi_data *applespi)
> > >  		return sts;
> > >  	}
> > >  
> > > -	applespi->cmd_msg_queued = true;
> > > +	applespi->cmd_msg_queued = ktime_get();
> > 
> > Will it be OK if I change this to ktime_get_coarse()? I do not think we
> > need exact time here, and the coarse variant is cheaper I believe.
> 
> Certainly - I just wasn't aware of the coarse variant.

Applied, thank you.

-- 
Dmitry