linux-kernel - [PATCH] fs: nfsd: fix kconfig dependency warning for NFSD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4276512.Scm06nC1gK@ubuntu-mate-laptop>
Date:   Fri, 19 Feb 2021 16:56:10 -0500
From:   Julian Braha <julianbraha@...il.com>
To:     bfields@...ldses.org
Cc:     linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] fs: nfsd: fix kconfig dependency warning for NFSD_V4

When NFSD_V4 is enabled and CRYPTO is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for CRYPTO_SHA256
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - NFSD_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFSD [=y] && PROC_FS [=y]

WARNING: unmet direct dependencies detected for CRYPTO_MD5
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - NFSD_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFSD [=y] && PROC_FS [=y]

This is because NFSD_V4 selects CRYPTO_MD5 and CRYPTO_SHA256,
without depending on or selecting CRYPTO, despite those config options
being subordinate to CRYPTO.

Signed-off-by: Julian Braha <julianbraha@...il.com>
--- a/fs/nfsd/Kconfig 2021-02-09 22:05:29.462030761 -0500
+++ b/fs/nfsd/Kconfig 2021-02-11 12:00:48.974076992 -0500
@@ -73,6 +73,7 @@
   select NFSD_V3
   select FS_POSIX_ACL
   select SUNRPC_GSS
+ select CRYPTO
   select CRYPTO_MD5
   select CRYPTO_SHA256
   select GRACE_PERIOD