linux-kernel - Re: Re: [PATCH] ASoC: Intel: Skylake: Fix missing check in skl_pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4644524e.89b27.177b8b932a0.Coremail.dinghao.liu@zju.edu.cn>
Date:   Fri, 19 Feb 2021 13:18:00 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Tom Rix" <trix@...hat.com>
Cc:     kjlu@....edu, "Cezary Rojewski" <cezary.rojewski@...el.com>,
        "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.intel.com>,
        "Liam Girdwood" <liam.r.girdwood@...ux.intel.com>,
        "Jie Yang" <yang.jie@...ux.intel.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>,
        "Kuninori Morimoto" <kuninori.morimoto.gx@...esas.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        "Julia Lawall" <Julia.Lawall@...ia.fr>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] ASoC: Intel: Skylake: Fix missing check in
 skl_pcm_trigger

> 
> On 2/15/21 7:13 AM, Dinghao Liu wrote:
> > When cmd == SNDRV_PCM_TRIGGER_STOP, we should also check
> > the return value of skl_decoupled_trigger() just like what
> > we have done in case SNDRV_PCM_TRIGGER_PAUSE_RELEASE.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> > ---
> >  sound/soc/intel/skylake/skl-pcm.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
> > index b1ca64d2f7ea..a5b1f333a500 100644
> > --- a/sound/soc/intel/skylake/skl-pcm.c
> > +++ b/sound/soc/intel/skylake/skl-pcm.c
> > @@ -516,6 +516,9 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
> >  			return ret;
> 
> Is there any additional error handling to be done for the
> 
> skl_stop_pipe that just happened ?
> 

I think the check is enough here.

Regards,
Dinghao