linux-kernel - [PATCH] drivers: firmware: fix kconfig dependency on CRYPTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 19 Feb 2021 18:46:10 -0500
From:   Julian Braha <julianbraha@...il.com>
To:     ardb@...nel.org
Cc:     linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] drivers: firmware: fix kconfig dependency on CRYPTO

commit 72304490d9df7d6af2e6851cc5762908abd52889
Author: Julian Braha <julianbraha@...il.com>
Date:   Fri Feb 19 18:36:22 2021 -0500

    drivers: firmware: fix kconfig dependency on CRYPTO
    
    When EFI_EMBEDDED_FIRMWARE is enabled and CRYPTO is disabled,
    Kbuild gives the following warning:
    
    WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
      Depends on [n]: CRYPTO [=n]
      Selected by [y]:
      - EFI_EMBEDDED_FIRMWARE [=y] && EFI [=y]
    
    This is because EFI_EMBEDDED_FIRMWARE selects CRYPTO_LIB_SHA256,
    without depending on or selecting CRYPTO, despite that config option
    being subordinate to CRYPTO.
    
    Signed-off-by: Julian Braha <julianbraha@...il.com>

diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 2c3dac5ecb36..f914da9845ac 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -248,6 +248,7 @@ endmenu
 config EFI_EMBEDDED_FIRMWARE
        bool
        depends on EFI
+       select CRYPTO
        select CRYPTO_LIB_SHA256
 
 config UEFI_CPER