linux-kernel - RE: [EXT] Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR04MB5848D5D763FF8EA0CAC9EC868C839@AM6PR04MB5848.eurprd04.prod.outlook.com>
Date:   Sat, 20 Feb 2021 01:27:11 +0000
From:   Richard Zhu <hongxing.zhu@....com>
To:     Krzysztof Wilczyński <kw@...ux.com>
CC:     "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "helgaas@...nel.org" <helgaas@...nel.org>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [EXT] Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp
 pcie


> -----Original Message-----
> From: Krzysztof Wilczyński <kw@...ux.com>
> Sent: Friday, February 19, 2021 1:34 AM
> To: Richard Zhu <hongxing.zhu@....com>
> Cc: l.stach@...gutronix.de; helgaas@...nel.org; stefan@...er.ch;
> lorenzo.pieralisi@....com; linux-pci@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; kernel@...gutronix.de
> Subject: [EXT] Re: [PATCH] PCI: imx6: Limit DBI register length for imx6qp pcie
> [...]
> > > Refer to commit 075af61c19cd ("PCI: imx6: Limit DBI register
> > > length"), i.MX6QP PCIe has the similar issue.
> > > Define the length of the DBI registers and limit config space to its
> > > length for i.MX6QP PCIe too.
> >
> > You could probably flip these two sentences around to make the commit
> > message read slightly better, so what about this (a suggestion):
> >
> > Define the length of the DBI registers and limit config space to its
> > length. This makes sure that the kernel does not access registers
> > beyond that point that otherwise would lead to an abort on a i.MX
> 6QuadPlus.
> >
> > See commit 075af61c19cd ("PCI: imx6: Limit DBI register length") that
> > resolves a similar issue on a i.MX 6Quad PCIe.
> [...]
> 
> If you do decide to send another version, then also use "PCIe" in the subject,
> rather than "pcie".  I forgot to mention this in the previous message,
> apologies.
> 
[Richard Zhu] Never mind. Thanks a lot for your comments.
Would issue another version a moment later.

Best Regards
Richard Zhu

> Krzysztof