linux-kernel - Re: [PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDCz/6gQgp07NGw2@kroah.com>
Date:   Sat, 20 Feb 2021 08:02:23 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Julian Braha <julianbraha@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO

On Fri, Feb 19, 2021 at 06:14:57PM -0500, Julian Braha wrote:
> commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0
> Author: Julian Braha <julianbraha@...il.com>
> Date:   Fri Feb 19 17:02:24 2021 -0500
> 
>     staging: rtl8192e: fix kconfig dependency on CRYPTO
>     
>     When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
>     Kbuild gives the following warning:
>     
>     WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
>       Depends on [n]: CRYPTO [=n]
>       Selected by [m]:
>       - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
>     
>     WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4
>       Depends on [n]: CRYPTO [=n]
>       Selected by [m]:
>       - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
>       - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m]
>     
>     This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and CRYPTO_LIB_ARC4,
>     without depending on or selecting CRYPTO, despite those config options
>     being subordinate to CRYPTO.
>     
>     Signed-off-by: Julian Braha <julianbraha@...il.com>
> 
> diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig
> index 03fcc23516fd..6e7d84ac06f5 100644
> --- a/drivers/staging/rtl8192e/Kconfig
> +++ b/drivers/staging/rtl8192e/Kconfig
> @@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP
>  config RTLLIB_CRYPTO_TKIP
>         tristate "Support for rtllib TKIP crypto"
>         depends on RTLLIB
> +      select CRYPTO
>         select CRYPTO_LIB_ARC4
>         select CRYPTO_MICHAEL_MIC
>         default y

Odd indentation :(