linux-kernel - Re: [PATCH] staging: wimax/i2400m: fix byte-order type issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YDJDW97X7k+mb/gE@kroah.com>
Date:   Sun, 21 Feb 2021 12:26:19 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     karthik alapati <mail@...thek.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Johannes Berg <johannes@...solutions.net>,
        Arnd Bergmann <arnd@...db.de>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wimax/i2400m: fix byte-order type issue

On Sat, Feb 20, 2021 at 06:22:31PM +0530, karthik alapati wrote:
> fix sparse type warning by converting le32 types to
> host byte-order types before comparison
> 
> Signed-off-by: karthik alapati <mail@...thek.com>
> ---
>  drivers/staging/wimax/i2400m/fw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
> index 92ea5c101..f09de1810 100644
> --- a/drivers/staging/wimax/i2400m/fw.c
> +++ b/drivers/staging/wimax/i2400m/fw.c
> @@ -511,7 +511,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode,
>  			opcode, i2400m_brh_get_response(ack));
>  		goto error_ack_failed;
>  	}
> -	if (ack_size < ack->data_size + sizeof(*ack)) {
> +	if (ack_size < le32_to_cpu(ack->data_size) + sizeof(*ack)) {
>  		dev_err(dev, "boot-mode cmd %d: SW BUG "
>  			"driver provided only %zu bytes for %zu bytes "
>  			"of data\n", opcode, ack_size,

You sent 3 patches that seem to do the same thing, yet are a bit
different?

Please make your patches a patch series and provide proper subject lines
to make them unique.  I have now dropped all of your submitted patches
from my review queue.

thanks,

greg k-h