linux-kernel - Re: [PATCH] arp: Remove the arp_hh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b69191b-9bd5-9050-9126-17b4905a67e9@gmail.com>
Date:   Sat, 20 Feb 2021 18:54:08 -0700
From:   David Ahern <dsahern@...il.com>
To:     Yejune Deng <yejune.deng@...il.com>, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, kuba@...nel.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arp: Remove the arp_hh_ops structure

On 2/19/21 9:32 PM, Yejune Deng wrote:
>  static const struct neigh_ops arp_direct_ops = {
>  	.family =		AF_INET,
>  	.output =		neigh_direct_output,
> @@ -277,15 +269,10 @@ static int arp_constructor(struct neighbour *neigh)
>  			memcpy(neigh->ha, dev->broadcast, dev->addr_len);
>  		}
>  
> -		if (dev->header_ops->cache)
> -			neigh->ops = &arp_hh_ops;
> -		else
> -			neigh->ops = &arp_generic_ops;

How did you test this?

you took out the neigh->ops assignment, so all of the neigh->ops in
net/core/neighbour.c are going to cause a NULL dereference.


> -
> -		if (neigh->nud_state & NUD_VALID)
> -			neigh->output = neigh->ops->connected_output;
> +		if (!dev->header_ops->cache && (neigh->nud_state & NUD_VALID))
> +			neigh->output = arp_generic_ops.connected_output;
>  		else
> -			neigh->output = neigh->ops->output;
> +			neigh->output = arp_generic_ops.output;
>  	}
>  	return 0;
>  }
>