linux-kernel - Re: [PATCH 2/2] staging: media: ipu3: code style fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 21 Feb 2021 09:20:45 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nikolay Kyx <knv418@...il.com>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Bingbu Cao <bingbu.cao@...el.com>,
        Tianshu Qiu <tian.shu.qiu@...el.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: media: ipu3: code style fix - missing a
 blank line after declarations

On Sun, Feb 21, 2021 at 11:12:36AM +0300, Nikolay Kyx wrote:
> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: Missing a blank line after declarations
> 
> in file ipu3-css-fw.h
> 
> Signed-off-by: Nikolay Kyx <knv418@...il.com>
> ---
> 
> Additionally some style warnings remain valid here and could be fixed by
> another patch.
> 
>  drivers/staging/media/ipu3/ipu3-css-fw.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css-fw.h b/drivers/staging/media/ipu3/ipu3-css-fw.h
> index 79ffa7045139..3c078f15a295 100644
> --- a/drivers/staging/media/ipu3/ipu3-css-fw.h
> +++ b/drivers/staging/media/ipu3/ipu3-css-fw.h
> @@ -148,6 +148,7 @@ union imgu_fw_union {
>  struct imgu_fw_info {
>  	size_t header_size;	/* size of fw header */
>  	u32 type __aligned(8);	/* enum imgu_fw_type */
> +
>  	union imgu_fw_union info;	/* Binary info */
>  	struct imgu_abi_blob_info blob;	/* Blob info */
>  	/* Dynamic part */

With your knowledge of C, does this change look correct?

thanks,

greg k-h