linux-kernel - Re: [PATCH] btrfs: ref-verify: use 'inline void' keyword ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210222174018.GS1993@twin.jikos.cz>
Date:   Mon, 22 Feb 2021 18:40:18 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Josef Bacik <jbacik@...com>,
        David Sterba <dsterba@...e.com>, Chris Mason <clm@...com>,
        linux-btrfs@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] btrfs: ref-verify: use 'inline void' keyword ordering

On Thu, Feb 18, 2021 at 10:54:17PM -0800, Randy Dunlap wrote:
> Fix build warnings of function signature when CONFIG_STACKTRACE is not
> enabled by reordering the 'inline' and 'void' keywords.
> 
> ../fs/btrfs/ref-verify.c:221:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
>  static void inline __save_stack_trace(struct ref_action *ra)
> ../fs/btrfs/ref-verify.c:225:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
>  static void inline __print_stack_trace(struct btrfs_fs_info *fs_info,
> 
> Fixes: fd708b81d972 ("Btrfs: add a extent ref verify tool")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Josef Bacik <jbacik@...com>
> Cc: David Sterba <dsterba@...e.com>
> Cc: Chris Mason <clm@...com>
> Cc: linux-btrfs@...r.kernel.org
> Cc: Andrew Morton <akpm@...ux-foundation.org>

Added to misc-next thanks.