[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b1d148cf-5264-54c7-1b6a-b0b4a5e866a1@linux.alibaba.com>
Date: Mon, 22 Feb 2021 13:05:54 +0800
From: Alex Shi <alex.shi@...ux.alibaba.com>
To: Masahiro Yamada <masahiroy@...nel.org>,
Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org
Cc: Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...ux.ie>,
Federico Vaga <federico.vaga@...a.pv.it>,
Harry Wei <harryxiyou@...il.com>, Jyri Sarha <jsarha@...com>,
Tomi Valkeinen <tomi.valkeinen@...com>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] doc: use KCFLAGS instead of EXTRA_CFLAGS to pass flags
from command line
Reviewed-by: Alex Shi <alex.shi@...ux.alibaba.com>
在 2021/2/21 下午11:25, Masahiro Yamada 写道:
> You should use KCFLAGS to pass additional compiler flags from the
> command line. Using EXTRA_CFLAGS is wrong.
>
> EXTRA_CFLAGS is supposed to specify flags applied only to the current
> Makefile (and now deprecated in favor of ccflags-y).
>
> It is still used in arch/mips/kvm/Makefile (and possibly in external
> modules too). Passing EXTRA_CFLAGS from the command line overwrites
> it and breaks the build.
>
> I also fixed drivers/gpu/drm/tilcdc/Makefile because commit 816175dd1fd7
> ("drivers/gpu/drm/tilcdc: Makefile, only -Werror when no -W* in
> EXTRA_CFLAGS") was based on the same misunderstanding.
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
> Documentation/process/4.Coding.rst | 2 +-
> Documentation/process/submit-checklist.rst | 2 +-
> Documentation/translations/it_IT/process/4.Coding.rst | 2 +-
> Documentation/translations/it_IT/process/submit-checklist.rst | 2 +-
> Documentation/translations/zh_CN/process/4.Coding.rst | 2 +-
> drivers/gpu/drm/tilcdc/Makefile | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
Powered by blists - more mailing lists