linux-kernel - Re: [PATCH net-next v2 2/3] net: ethernet: rmnet: Support for downlink MAPv5 checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202102230358.bmAq2nwP-lkp@intel.com>
Date:   Tue, 23 Feb 2021 03:49:10 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sharath Chandra Vurukala <sharathv@...eaurora.org>,
        davem@...emloft.net, kuba@...nel.org, elder@...nel.org,
        cpratapa@...eaurora.org, subashab@...eaurora.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org,
        Sharath Chandra Vurukala <sharathv@...eaurora.org>
Subject: Re: [PATCH net-next v2 2/3] net: ethernet: rmnet: Support for
 downlink MAPv5 checksum offload

Hi Sharath,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Sharath-Chandra-Vurukala/net-qualcomm-rmnet-Enable-Mapv5/20210223-010109
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d310ec03a34e92a77302edb804f7d68ee4f01ba0
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a96da20e1028049cc3824b52bb5293376c0868ce
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sharath-Chandra-Vurukala/net-qualcomm-rmnet-Enable-Mapv5/20210223-010109
        git checkout a96da20e1028049cc3824b52bb5293376c0868ce
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/kernel.h:10,
                    from include/linux/list.h:9,
                    from include/linux/timer.h:5,
                    from include/linux/netdevice.h:24,
                    from drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:7:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra]
     174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory)
         |                                                 ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   In file included from drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h:7,
                    from drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c:14:
   include/linux/if_rmnet.h: At top level:
>> include/linux/if_rmnet.h:66:2: error: expected ',', ';' or '}' before 'u8'
      66 |  u8  hw_reserved:7;
         |  ^~


vim +66 include/linux/if_rmnet.h

    54	
    55	/* MAP CSUM headers */
    56	struct rmnet_map_v5_csum_header {
    57	#if defined(__LITTLE_ENDIAN_BITFIELD)
    58		u8  next_hdr:1;
    59		u8  header_type:7;
    60		u8  hw_reserved:7;
    61		u8  csum_valid_required:1;
    62	#elif defined(__BIG_ENDIAN_BITFIELD)
    63		u8  header_type:7;
    64		u8  next_hdr:1;
    65		u8  csum_valid_required:1
  > 66		u8  hw_reserved:7;
    67	#else
    68	#error	"Please fix <asm/byteorder.h>"
    69	#endif
    70		__be16 reserved;
    71	} __aligned(1);
    72	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (59709 bytes)