linux-kernel - [PATCH] sound: soc: codecs: fix kconfig dependency on GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210222214444.23340-1-julianbraha@gmail.com>
Date:   Mon, 22 Feb 2021 16:44:44 -0500
From:   Julian Braha <julianbraha@...il.com>
To:     perex@...ex.cz
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: [PATCH] sound: soc: codecs: fix kconfig dependency on GPIOLIB

When SND_SOC_DMIC is enabled and GPIOLIB is disabled,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for SND_SOC_DMIC
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
  Selected by [y]:
  - SND_SOC_AMD_RENOIR_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_RENOIR [=y]

This is because SND_SOC_AMD_RENOIR_MACH selects SND_SOC_DMIC,
without depending on or selecting GPIOLIB, despite that config option
depending on GPIOLIB.

Signed-off-by: Julian Braha <julianbraha@...il.com>
---
 sound/soc/amd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index a6ce000fac3f..5480dff7a1ad 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -46,6 +46,7 @@ config SND_SOC_AMD_RENOIR
 
 config SND_SOC_AMD_RENOIR_MACH
 	tristate "AMD Renoir support for DMIC"
+	select GPIOLIB
 	select SND_SOC_DMIC
 	depends on SND_SOC_AMD_RENOIR
 	help
-- 
2.27.0