linux-kernel - [PATCH] scsi: qedf: Switch to using the new API kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1613979266-13667-1-git-send-email-yang.lee@linux.alibaba.com>
Date:   Mon, 22 Feb 2021 15:34:26 +0800
From:   Yang Li <yang.lee@...ux.alibaba.com>
To:     skashyap@...vell.com
Cc:     jhasan@...vell.com, GR-QLogic-Storage-Upstream@...vell.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yang Li <yang.lee@...ux.alibaba.com>
Subject: [PATCH] scsi: qedf: Switch to using the new API kobj_to_dev()

fixed the following coccicheck:
./drivers/scsi/qedf/qedf_attr.c:105:26-27: WARNING opportunity for
kobj_to_dev()
./drivers/scsi/qedf/qedf_attr.c:134:24-25: WARNING opportunity for
kobj_to_dev()

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
---
 drivers/scsi/qedf/qedf_attr.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/qedf/qedf_attr.c b/drivers/scsi/qedf/qedf_attr.c
index d995f72..33d2281 100644
--- a/drivers/scsi/qedf/qedf_attr.c
+++ b/drivers/scsi/qedf/qedf_attr.c
@@ -101,8 +101,7 @@ void qedf_capture_grc_dump(struct qedf_ctx *qedf)
 			size_t count)
 {
 	ssize_t ret = 0;
-	struct fc_lport *lport = shost_priv(dev_to_shost(container_of(kobj,
-							struct device, kobj)));
+	struct fc_lport *lport = shost_priv(dev_to_shost(kobj_to_dev(kobj)));
 	struct qedf_ctx *qedf = lport_priv(lport);
 
 	if (test_bit(QEDF_GRCDUMP_CAPTURE, &qedf->flags)) {
@@ -130,8 +129,7 @@ void qedf_capture_grc_dump(struct qedf_ctx *qedf)
 		return ret;
 
 
-	lport = shost_priv(dev_to_shost(container_of(kobj,
-	    struct device, kobj)));
+	lport = shost_priv(dev_to_shost(kobj_to_dev(kobj)));
 	qedf = lport_priv(lport);
 
 	buf[1] = 0;
-- 
1.8.3.1