linux-kernel - RE: RE: [PATCH v21 4/4] scsi: ufs: Add HPB 2.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210222082155epcms2p4bf924773e8497cf75d72ab9eef1a0d1c@epcms2p4>
Date:   Mon, 22 Feb 2021 17:21:55 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     Avri Altman <Avri.Altman@....com>,
        Daejun Park <daejun7.park@...sung.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "bvanassche@....org" <bvanassche@....org>,
        "huobean@...il.com" <huobean@...il.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        JinHwan Park <jh.i.park@...sung.com>,
        Javier Gonzalez <javier.gonz@...sung.com>,
        SEUNGUK SHIN <seunguk.shin@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        yongmyung lee <ymhungry.lee@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        BoRam Shin <boram.shin@...sung.com>
Subject: RE: RE: [PATCH v21 4/4] scsi: ufs: Add HPB 2.0 support

> >         kmem_cache_destroy(hpb->map_req_cache);
> > @@ -1670,7 +2109,7 @@ void ufshpb_init_hpb_lu(struct ufs_hba *hba, struct
> > scsi_device *sdev)
> >         if (ret)
> >                 goto out;
> > 
> > -       hpb = ufshpb_alloc_hpb_lu(hba, lun, &hba->ufshpb_dev,
> > +       hpb = ufshpb_alloc_hpb_lu(hba, sdev, &hba->ufshpb_dev,
> >                                   &hpb_lu_info);
> >         if (!hpb)
> >                 goto out;
> In HPB2.0 device control mode, the host is expected to send HPB-WRITE-BUFFER 0x3
> To informs that all HPB Regions are inactive (expect for pinned regions).
> Maybe a good place to do so is here, or in ufshpb_hpb_lu_prepared after you kicked the map work for pinned regions.

Done

> Either way, If you decide to do so, I would appreciate if you could align to the framework I proposed in
> (scsi: ufshpb: Region inactivation in host mode).
> This way you would have a wrapper unmap_all that would call ufshpb_issue_umap_req with buffer id 0x3,
> And I would have a wrapper unmap_single that would call it with buffer id 0x1.

I will do this way on the next patch.

Thanks,
Daejun