linux-kernel - Re: [PATCH] scsi: iscsi: Switch to using the new API kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4fa2baa0-8727-9e72-eb42-db773401b8a1@huawei.com>
Date:   Mon, 22 Feb 2021 08:30:57 +0000
From:   John Garry <john.garry@...wei.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, <martin.petersen@...cle.com>
CC:     <jejb@...ux.ibm.com>, <lduncan@...e.com>, <cleech@...hat.com>,
        <open-iscsi@...glegroups.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev()

On 22/02/2021 07:26, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/scsi/scsi_transport_iscsi.c:436:60-61: WARNING opportunity for
> kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:1128:60-61: WARNING opportunity
> for kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:4043:61-62: WARNING opportunity
> for kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:4312:61-62: WARNING opportunity
> for kobj_to_dev()
> ./drivers/scsi/scsi_transport_iscsi.c:4456:61-62: WARNING opportunity
> for kobj_to_dev()

that API is not new, so please in future stop writing that. And 'new' is 
a time-dependent term, and not appropriate to use anyway.

Thanks,
John

> 
> Reported-by: Abaci Robot<abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li<yang.lee@...ux.alibaba.com>