linux-kernel - Re: [PATCH] vt: convert sysfs sprintf/snprintf family to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Feb 2021 09:53:40 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     jirislaby@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vt: convert sysfs sprintf/snprintf family to sysfs_emit

On Mon, Feb 22, 2021 at 04:48:49PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warning:
> 
> ./drivers/tty/vt/vt.c:3909:8-16: WARNING: use scnprintf or sprintf.
> ./drivers/tty/vt/vt.c:3917:8-16: WARNING: use scnprintf or sprintf

Why?

You say what you did, but there is no justification for why this is
required in the tree.

> 
> Reported-by: Abaci Robot<abaci@...ux.alibaba.com>

You forgot a ' '.

> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/tty/vt/vt.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 284b072..cdf8132 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -3906,7 +3906,7 @@ static ssize_t show_bind(struct device *dev, struct device_attribute *attr,
>  	bind = con_is_bound(con->con);
>  	console_unlock();
>  
> -	return snprintf(buf, PAGE_SIZE, "%i\n", bind);
> +	return sysfs_emit(buf, "%i\n", bind);
>  }
>  
>  static ssize_t show_name(struct device *dev, struct device_attribute *attr,
> @@ -3914,9 +3914,8 @@ static ssize_t show_name(struct device *dev, struct device_attribute *attr,
>  {
>  	struct con_driver *con = dev_get_drvdata(dev);
>  
> -	return snprintf(buf, PAGE_SIZE, "%s %s\n",
> -			(con->flag & CON_DRIVER_FLAG_MODULE) ? "(M)" : "(S)",
> -			 con->desc);
> +	return sysfs_emit(buf, "%s %s\n", (con->flag & CON_DRIVER_FLAG_MODULE) ? "(M)" : "(S)",
> +			  con->desc);

Why make the line longer now?  Can't this be a 1 line change here?

And why is this needed?

thanks,

greg k-h