linux-kernel - Re: [PATCH 08/16] media: i2c: max9286: Adjust parameters indent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Feb 2021 03:20:00 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Jacopo Mondi <jacopo+renesas@...ndi.org>
Cc:     kieran.bingham+renesas@...asonboard.com,
        niklas.soderlund+renesas@...natech.se, geert@...ux-m68k.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/16] media: i2c: max9286: Adjust parameters indent

Hi Jacopo,

Thank you for the patch.

On Tue, Feb 16, 2021 at 06:41:38PM +0100, Jacopo Mondi wrote:
> The parameters to max9286_i2c_mux_configure() fits on the previous
> line. Adjust it.
> 
> Cosmetic change only.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>
> ---
>  drivers/media/i2c/max9286.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index 6fd4d59fcc72..1d9951215868 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -287,9 +287,8 @@ static int max9286_i2c_mux_select(struct i2c_mux_core *muxc, u32 chan)
>  
>  	priv->mux_channel = chan;
>  
> -	max9286_i2c_mux_configure(priv,
> -				  MAX9286_FWDCCEN(chan) |
> -				  MAX9286_REVCCEN(chan));
> +	max9286_i2c_mux_configure(priv, MAX9286_FWDCCEN(chan) |
> +					MAX9286_REVCCEN(chan));

I feel obliged to say I would have written

	max9286_i2c_mux_configure(priv, MAX9286_FWDCCEN(chan) |
				  MAX9286_REVCCEN(chan));

:-)

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

>  
>  	return 0;
>  }

-- 
Regards,

Laurent Pinchart