linux-kernel - Re: [PATCH v6 1/2] drivers/misc: sysgenid: add system generation id driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YDN/AvsplZ7R8OTR@kroah.com>
Date:   Mon, 22 Feb 2021 10:53:06 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Adrian Catangiu <acatan@...zon.com>
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        qemu-devel@...gnu.org, kvm@...r.kernel.org,
        linux-s390@...r.kernel.org, graf@...zon.com, rdunlap@...radead.org,
        arnd@...db.de, ebiederm@...ssion.com, rppt@...nel.org,
        0x7f454c46@...il.com, borntraeger@...ibm.com, Jason@...c4.com,
        jannh@...gle.com, w@....eu, colmmacc@...zon.com, luto@...nel.org,
        tytso@....edu, ebiggers@...nel.org, dwmw@...zon.co.uk,
        bonzini@....org, sblbir@...zon.com, raduweis@...zon.com,
        corbet@....net, mst@...hat.com, mhocko@...nel.org,
        rafael@...nel.org, pavel@....cz, mpe@...erman.id.au,
        areber@...hat.com, ovzxemul@...il.com, avagin@...il.com,
        ptikhomirov@...tuozzo.com, gil@...l.com, asmehra@...hat.com,
        dgunigun@...hat.com, vijaysun@...ibm.com, oridgar@...il.com,
        ghammer@...hat.com
Subject: Re: [PATCH v6 1/2] drivers/misc: sysgenid: add system generation id
 driver

On Mon, Feb 22, 2021 at 11:41:25AM +0200, Adrian Catangiu wrote:
> The driver also generates a `SYSGENID=%u` uevent containing the new
> system generation counter/id value every time it changes. Unlike the
> filesystem interface, the uevent has no synchronization guarantees
> therefore it should not be used by any sensitive system components.

No, please no.  It is not ok to start sending random uevents all the
time to userspace for individual drivers like this.  Especially for a
misc device.

As you say "has no synchromization guarantees", then why use it at all?

Please drop it.

thanks,

greg k-h