linux-kernel - Re: [PATCH] netdevsim: fib: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YDOAMdp8pWXG+reW@shredder.lan>
Date:   Mon, 22 Feb 2021 11:58:09 +0200
From:   Ido Schimmel <idosch@...sch.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     kuba@...nel.org, davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netdevsim: fib: remove unneeded semicolon

On Mon, Feb 22, 2021 at 05:47:04PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/net/netdevsim/fib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
> index 46fb414..11b43ce 100644
> --- a/drivers/net/netdevsim/fib.c
> +++ b/drivers/net/netdevsim/fib.c
> @@ -561,7 +561,7 @@ static void nsim_fib6_rt_nh_del(struct nsim_fib6_rt *fib6_rt,
>  err_fib6_rt_nh_del:
>  	for (i--; i >= 0; i--) {
>  		nsim_fib6_rt_nh_del(fib6_rt, rt_arr[i]);
> -	};
> +	}

You can simply remove the braces since they are not needed

>  	nsim_fib_rt_fini(&fib6_rt->common);
>  	kfree(fib6_rt);
>  	return ERR_PTR(err);
> -- 
> 1.8.3.1
>