linux-kernel - Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=hENeCXGtKrXxLof=DEZjxpKyYBFS80pAX20nnJBuP_s-GBA@mail.gmail.com>
Date:   Mon, 22 Feb 2021 10:39:20 +0800
From:   Zhu Yanjun <zyjzyj2000@...il.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Julian Braha <julianbraha@...il.com>,
        Doug Ledford <dledford@...hat.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky <leon@...nel.org> wrote:
>
> On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote:
> > commit 6e61907779ba99af785f5b2397a84077c289888a
> > Author: Julian Braha <julianbraha@...il.com>
> > Date:   Fri Feb 19 18:20:57 2021 -0500
> >
> >     drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO
> >
> >     When RDMA_RXE is enabled and CRYPTO is disabled,
> >     Kbuild gives the following warning:
> >
> >     WARNING: unmet direct dependencies detected for CRYPTO_CRC32
> >       Depends on [n]: CRYPTO [=n]
> >       Selected by [y]:
> >       - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y]
> >
> >     This is because RDMA_RXE selects CRYPTO_CRC32,
> >     without depending on or selecting CRYPTO, despite that config option
> >     being subordinate to CRYPTO.
> >
> >     Signed-off-by: Julian Braha <julianbraha@...il.com>
>
> Please use git sent-email to send patches and please fix crypto Kconfig
> to enable CRYPTO if CRYPTO_* selected.
>
> It is a little bit awkward to request all users of CRYPTO_* to request
> select CRYPTO too.

The same issue and similar patch is in this link:

https://patchwork.kernel.org/project/linux-rdma/patch/20200915101559.33292-1-fazilyildiran@gmail.com/#23615747

Zhu Yanjun

>
> Thanks
>
> >
> > diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig
> > index 452149066792..06b8dc5093f7 100644
> > --- a/drivers/infiniband/sw/rxe/Kconfig
> > +++ b/drivers/infiniband/sw/rxe/Kconfig
> > @@ -4,6 +4,7 @@ config RDMA_RXE
> >         depends on INET && PCI && INFINIBAND
> >         depends on INFINIBAND_VIRT_DMA
> >         select NET_UDP_TUNNEL
> > +      select CRYPTO
> >         select CRYPTO_CRC32
> >         help
> >         This driver implements the InfiniBand RDMA transport over
> >
> >
> >