linux-kernel - Re: [PATCH v2 1/3] pwm: mtk_disp: clear the clock operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDO/0Onf6a09YRsP@ulmo.localdomain>
Date:   Mon, 22 Feb 2021 15:29:36 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Jitao Shi <jitao.shi@...iatek.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        linux-pwm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        srv_heupstream@...iatek.com, yingjoe.chen@...iatek.com,
        eddie.huang@...iatek.com, cawa.cheng@...iatek.com,
        bibby.hsieh@...iatek.com, ck.hu@...iatek.com, stonea168@....com,
        huijuan.xie@...iatek.com
Subject: Re: [PATCH v2 1/3] pwm: mtk_disp: clear the clock operations

On Sat, Jan 30, 2021 at 10:12:24PM +0800, Jitao Shi wrote:
> Remove the clk_prepare from mtk_disp_pwm_probe.
> Remove the clk_unprepare from mtk_disp_pwm_remove.
> 
> Signed-off-by: Jitao Shi <jitao.shi@...iatek.com>
> ---
>  drivers/pwm/pwm-mtk-disp.c | 23 ++---------------------
>  1 file changed, 2 insertions(+), 21 deletions(-)

It's not clear *why* you're doing this change. It's already obvious from
the changes in this patch that you're removing the calls to
clk_prepare() and clk_unprepare(), so instead of duplicating that
information in the commit message, take this opportunity to describe why
this change is needed. Without any further context, this would seem to
just break operation of this chip because now these clocks are never
enabled in the first place.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)