linux-kernel - Re: [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a58a45c-d67a-cdec-3858-7b50bdf2d4b7@a-kobel.de>
Date:   Mon, 22 Feb 2021 16:21:29 +0100
From:   Alexander Kobel <a-kobel@...obel.de>
To:     Alban Bedel <albeu@...e.fr>, Alex Hung <alex.hung@...onical.com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1
 Tablet Gen 2

Hi,

LGTM. Tested on an affected device (20JCS00C00). Works like a charm.


Thanks,
Alex


On 2/22/21 3:15 PM, Alban Bedel wrote:
> Like a few other system the Lenovo ThinkPad X1 Tablet Gen 2 miss the
> HEBC method, which prevent the power button from working. Add a quirk
> to enable the button array on this system family and fix the power
> button.
> 
> Signed-off-by: Alban Bedel <albeu@...e.fr>
> ---
>  drivers/platform/x86/intel-hid.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
> index 2f5b8d09143e..57cc92891a57 100644
> --- a/drivers/platform/x86/intel-hid.c
> +++ b/drivers/platform/x86/intel-hid.c
> @@ -90,6 +90,13 @@ static const struct dmi_system_id button_array_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "HP Spectre x2 Detachable"),
>  		},
>  	},
> +	{
> +		.ident = "Lenovo ThinkPad X1 Tablet Gen 2",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "ThinkPad X1 Tablet Gen 2"),
> +		},
> +	},
>  	{ }
>  };
>  
> 


Download attachment "smime.p7s" of type "application/pkcs7-signature" (5916 bytes)