linux-kernel - Re: [PATCH v8 12/22] counter: Rename counter_count_function to counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDSPQFMd0sqUBUaq@shinobu>
Date:   Tue, 23 Feb 2021 14:14:40 +0900
From:   William Breathitt Gray <vilhelm.gray@...il.com>
To:     David Lechner <david@...hnology.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, kernel@...gutronix.de,
        linux-stm32@...md-mailman.stormreply.com, a.fatoum@...gutronix.de,
        kamel.bouhara@...tlin.com, gwendal@...omium.org,
        alexandre.belloni@...tlin.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        syednwaris@...il.com, patrick.havelange@...ensium.com,
        fabrice.gasnier@...com, mcoquelin.stm32@...il.com,
        alexandre.torgue@...com, o.rempel@...gutronix.de
Subject: Re: [PATCH v8 12/22] counter: Rename counter_count_function to
 counter_function

On Sat, Feb 20, 2021 at 10:56:13AM -0600, David Lechner wrote:
> On 2/14/21 11:13 AM, Jonathan Cameron wrote:
> > On Fri, 12 Feb 2021 21:13:36 +0900
> > William Breathitt Gray <vilhelm.gray@...il.com> wrote:
> > 
> >> The phrase "Counter Count function" is verbose and unintentionally
> >> implies that function is a Count extension. This patch adjusts the
> >> Counter subsystem code to use the more direct "Counter function" phrase
> >> to make the intent of this code clearer. The phrase "Count action" is
> >> adjusted herein as well for the same reason.
> >>
> >> Cc: Syed Nayyar Waris <syednwaris@...il.com>
> >> Cc: Patrick Havelange <patrick.havelange@...ensium.com>
> >> Cc: Kamel Bouhara <kamel.bouhara@...tlin.com>
> >> Cc: Fabrice Gasnier <fabrice.gasnier@...com>
> >> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
> >> Cc: Alexandre Torgue <alexandre.torgue@...com>
> >> Cc: David Lechner <david@...hnology.com>
> >> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> > 
> > I agree this makes sense in the counter core code, but in the drivers
> > it may not be quite so obvious we are talking about a counter function
> > given some of the bits of hardware do a number of other things.
> > 
> > I guess up to the various driver maintainers on whether they
> > think the new meaning is clear enough!
> > 
> > Jonathan
> > 
> 
> TBH, I think "counter count function" makes more sense to me.

That's a fair point. I'll revert this for the individual drivers and
leave it up to the maintainers if they want to adjust their namings.
Instead, I'll limit the name changes to the counter core code.

William Breathitt Gray


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)