linux-kernel - Re: [PATCH] sound: core: fixed coding style errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hh7m3wanq.wl-tiwai@suse.de>
Date:   Tue, 23 Feb 2021 07:39:05 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Rajesh Kumbhakar <sssraj.sssraj@...il.com>
Cc:     perex@...ex.cz, tiwai@...e.com, sfr@...b.auug.org.au,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: core: fixed coding style errors

On Mon, 22 Feb 2021 20:41:56 +0100,
Rajesh Kumbhakar wrote:
> 
> fixing ERROR: "foo * bar" should be "foo *bar"
> fixing WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj@...il.com>
> ---
>  sound/core/hwdep_compat.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/core/hwdep_compat.c b/sound/core/hwdep_compat.c
> index a0b76706c..d8624a14a 100644
> --- a/sound/core/hwdep_compat.c
> +++ b/sound/core/hwdep_compat.c
> @@ -36,11 +36,13 @@ enum {
>  	SNDRV_HWDEP_IOCTL_DSP_LOAD32   = _IOW('H', 0x03, struct snd_hwdep_dsp_image32)
>  };
>  
> -static long snd_hwdep_ioctl_compat(struct file * file, unsigned int cmd,
> +static long snd_hwdep_ioctl_compat(struct file *file, unsigned int cmd,
>  				   unsigned long arg)
>  {
>  	struct snd_hwdep *hw = file->private_data;
> +
>  	void __user *argp = compat_ptr(arg);

You shouldn't put a blank line here.


thanks,

Takashi