linux-kernel - Re: [PATCH 5.10 03/29] vdpa_sim: store parsed MAC address in a buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Feb 2021 09:06:55 +0100
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jason Wang <jasowang@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH 5.10 03/29] vdpa_sim: store parsed MAC address in a buffer

On Mon, Feb 22, 2021 at 08:54:15PM +0100, Pavel Machek wrote:
>Hi!
>
>> From: Stefano Garzarella <sgarzare@...hat.com>
>>
>> commit cf1a3b35382c10ce315c32bd2b3d7789897fbe13 upstream.
>>
>> As preparation for the next patches, we store the MAC address,
>> parsed during the vdpasim_create(), in a buffer that will be used
>> to fill 'config' together with other configurations.
>
>I'm not sure why this series is in stable. It is not documented to fix
>anything bad.
>
>> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
>> @@ -42,6 +42,8 @@ static char *macaddr;
>>  module_param(macaddr, charp, 0);
>>  MODULE_PARM_DESC(macaddr, "Ethernet MAC address");
>>
>> +u8 macaddr_buf[ETH_ALEN];
>> +
>
>Should this be static?

Yes, there is already a patch [1] queued by Michael but not yet 
upstream. When it will be merged upstream I will make sure it will be 
backported.

Thanks,
Stefano

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?h=linux-next&id=8c0bea4adac9f1f9ac827210fa8862be4bde6290