linux-kernel - Re: [PATCH 1/2] leds: bcm6328: improve write and read functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210223085819.GB9750@amd>
Date:   Tue, 23 Feb 2021 09:58:19 +0100
From:   Pavel Machek <pavel@....cz>
To:     Álvaro Fernández Rojas <noltari@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Dan Murphy <dmurphy@...com>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] leds: bcm6328: improve write and read functions

Hi!

> >> This is proven to work in BMIPS BE/LE and ARM BE/LE, as used in bcm2835-rng
> >> and bcmgenet drivers.
> >> Both should also be inline functions.
> > 
> > 
> > 
> >> -#ifdef CONFIG_CPU_BIG_ENDIAN
> >> -	iowrite32be(data, reg);
> >> -#else
> >> -	writel(data, reg);
> >> -#endif
> >> +	/* MIPS chips strapped for BE will automagically configure the
> >> +	 * peripheral registers for CPU-native byte order.
> >> +	 */
> > 
> > Bad comment style.
> 
> I just wanted to copy the same comment as the one in bcm2835-rng and bcmgenet…
> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/char/hw_random/bcm2835-rng.c#L42-L60
> https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef100731/drivers/net/ethernet/broadcom/genet/bcmgenet.c#L71-L88
>

Yeah, but ideally you should not be copying comments; there should be
one central place which does it and does it right.

								Pavel

-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)