linux-kernel - Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.12-1 tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k0qztxi6.fsf@mpe.ellerman.id.au>
Date:   Tue, 23 Feb 2021 11:53:53 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Oliver O'Halloran <oohall@...il.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Alexey Kardashevskiy <aik@...abs.ru>,
        Ananth N Mavinakayanahalli <ananth@...ux.ibm.com>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
        Athira Jajeev <atrajeev@...ux.vnet.ibm.com>,
        Qian Cai <cai@....pw>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Cédric Le Goater <clg@...d.org>,
        cmr@...efail.de, cy.fan@...wei.com, eerykitty@...il.com,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Frederic Barrat <fbarrat@...ux.ibm.com>,
        ganeshgr@...ux.ibm.com, Haren Myneni <haren@...ux.ibm.com>,
        Hari Bathini <hbathini@...ux.ibm.com>,
        jiapeng.chong@...ux.alibaba.com,
        Pingfan Liu <kernelfans@...il.com>, kjain@...ux.ibm.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Michal Suchanek <msuchanek@...e.de>,
        Nathan Lynch <nathanl@...ux.ibm.com>,
        Nick Piggin <npiggin@...il.com>,
        Po-Hsu Lin <po-hsu.lin@...onical.com>,
        Randy Dunlap <rdunlap@...radead.org>, sandipan@...ux.ibm.com,
        skirmisher@...tonmail.com,
        Bhaskar Chowdhury <unixbhaskar@...il.com>,
        Zheng Yongjun <zhengyongjun3@...wei.com>,
        Rob Herring <robh@...nel.org>, Mark Brown <broonie@...nel.org>
Subject: Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.12-1 tag

"Oliver O'Halloran" <oohall@...il.com> writes:

> On Tue, Feb 23, 2021 at 9:44 AM Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
>>
>> On Mon, Feb 22, 2021 at 4:06 AM Michael Ellerman <mpe@...erman.id.au> wrote:
>> >
>> > Please pull powerpc updates for 5.12.
>>
>> Pulled. However:
>>
>> >  mode change 100755 => 100644 tools/testing/selftests/powerpc/eeh/eeh-functions.sh
>> >  create mode 100755 tools/testing/selftests/powerpc/eeh/eeh-vf-aware.sh
>> >  create mode 100755 tools/testing/selftests/powerpc/eeh/eeh-vf-unaware.sh
>>
>> Somebody is being confused.
>>
>> Why create two new shell scripts with the proper executable bit, and
>> then remove the executable bit from an existing one?
>>
>> That just seems very inconsistent.
>
> eeh-function.sh just provides some helper functions for the other
> scripts and doesn't do anything when executed directly. I thought
> making it non-executable made sense.

Yeah I think it does make sense. It just looks a bit odd in the diffstat
like this. Maybe if we called it lib.sh it would be more obvious?

cheers