linux-kernel - Re: [PATCH] gpiolib: acpi: Add missing IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Feb 2021 13:51:53 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     mika.westerberg@...ux.intel.com, linus.walleij@...aro.org,
        bgolaszewski@...libre.com, linux-gpio@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: Add missing IRQF_ONESHOT

On Tue, Feb 23, 2021 at 04:35:58PM +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/gpio/gpiolib-acpi.c:176:7-27: ERROR: Threaded IRQ with no
> primary handler requested without IRQF_ONESHOT
> 
> Make sure threaded IRQs without a primary handler are always request
> with IRQF_ONESHOT

Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/gpio/gpiolib-acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index e37a57d..86efa2d 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -174,7 +174,7 @@ static void acpi_gpiochip_request_irq(struct acpi_gpio_chip *acpi_gpio,
>  	int ret, value;
>  
>  	ret = request_threaded_irq(event->irq, NULL, event->handler,
> -				   event->irqflags, "ACPI:Event", event);
> +				   event->irqflags | IRQF_ONESHOT, "ACPI:Event", event);
>  	if (ret) {
>  		dev_err(acpi_gpio->chip->parent,
>  			"Failed to setup interrupt handler for %d\n",
> -- 
> 1.8.3.1
> 

-- 
With Best Regards,
Andy Shevchenko