linux-kernel - Re: [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Feb 2021 13:13:54 +0000
From:   Alexander Lobakin <alobakin@...me>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Alexander Lobakin <alobakin@...me>, Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Huacai Chen <chenhuacai@...nel.org>,
        Pei Huang <huangpei@...ngson.cn>,
        Kees Cook <keescook@...omium.org>,
        Fangrui Song <maskray@...gle.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Corey Minyard <cminyard@...sta.com>,
        kernel test robot <lkp@...el.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org
Subject: Re: [PATCH mips-fixes] vmlinux.lds.h: catch even more instrumentation symbols into .data

From: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Date: Tue, 23 Feb 2021 13:21:44 +0100

> On Tue, Feb 23, 2021 at 11:36:41AM +0000, Alexander Lobakin wrote:
> > > LKP caught another bunch of orphaned instrumentation symbols [0]:
> > >
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > > `init/main.o' being placed in section `.data.$LPBX1'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > > `init/main.o' being placed in section `.data.$LPBX0'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > > `init/do_mounts.o' being placed in section `.data.$LPBX1'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > > `init/do_mounts.o' being placed in section `.data.$LPBX0'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > > `init/do_mounts_initrd.o' being placed in section `.data.$LPBX1'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > > `init/do_mounts_initrd.o' being placed in section `.data.$LPBX0'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > > `init/initramfs.o' being placed in section `.data.$LPBX1'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > > `init/initramfs.o' being placed in section `.data.$LPBX0'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX1' from
> > > `init/calibrate.o' being placed in section `.data.$LPBX1'
> > > mipsel-linux-ld: warning: orphan section `.data.$LPBX0' from
> > > `init/calibrate.o' being placed in section `.data.$LPBX0'
> > >
> > > [...]
> > >
> > > Soften the wildcard to .data.$L* to grab these ones into .data too.
> > >
> > > [0] https://lore.kernel.org/lkml/202102231519.lWPLPveV-lkp@intel.com
> > >
> > > Reported-by: kernel test robot <lkp@...el.com>
> > > Signed-off-by: Alexander Lobakin <alobakin@...me>
> > > ---
> > >  include/asm-generic/vmlinux.lds.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Hi Thomas,
> >
> > This applies on top of mips-next or Linus' tree, so you may need to
> > rebase mips-fixes before taking it.
> > It's not for mips-next as it should go into this cycle as a [hot]fix.
> > I haven't added any "Fixes:" tag since these warnings is a result
> > of merging several sets and of certain build configurations that
> > almost couldn't be tested separately.
>
> no worries, mips-fixes is defunct during merge windows. I'll send another
> pull request to Linus and will add this patch to it.

Ah, thank you!

> Thomas.

Al

> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]