linux-kernel - [PATCH] scripts/gdb: fix 'lx-symbols' section parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 23 Feb 2021 15:09:47 +0100
From:   Julian Blaauboer <julian.blaauboer@...il.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kbingham@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Julian Blaauboer <julian.blaauboer@...il.com>
Subject: [PATCH] scripts/gdb: fix 'lx-symbols' section parsing

Loading a module using 'lx-symbols' in GDB would result in a
gdb.MemoryError when parsing the section names and addresses because of
the way GDB handles flexible array members. This patch fixes that issue
by converting the 'struct module_sect_attr[]' into a pointer before
accessing it.

Signed-off-by: Julian Blaauboer <julian.blaauboer@...il.com>
---
 scripts/gdb/linux/symbols.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
index 1be9763cf8bb..6d3a33a00189 100644
--- a/scripts/gdb/linux/symbols.py
+++ b/scripts/gdb/linux/symbols.py
@@ -94,7 +94,8 @@ lx-symbols command."""
             sect_attrs = module['sect_attrs'].dereference()
         except gdb.error:
             return ""
-        attrs = sect_attrs['attrs']
+        # Convert from struct module_sect_attr[] to struct module_sect_attr*
+        attrs = sect_attrs['attrs'].dereference().address
         section_name_to_address = {
             attrs[n]['battr']['attr']['name'].string(): attrs[n]['address']
             for n in range(int(sect_attrs['nsections']))}
-- 
2.30.1