linux-kernel - Re: [PATCH] tty/serial:Remove superfluous "breaks"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210223142348.7wsgp4qdpkmkcmmz@pengutronix.de>
Date:   Tue, 23 Feb 2021 15:23:48 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     dingsenjie@....com
Cc:     gregkh@...uxfoundation.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, dingsenjie <dingsenjie@...ong.com>
Subject: Re: [PATCH] tty/serial:Remove superfluous "breaks"

On Tue, Feb 23, 2021 at 04:06:30PM +0800, dingsenjie@....com wrote:
> From: dingsenjie <dingsenjie@...ong.com>
> 
> Remove superfluous "breaks", as there is a "return" before them.
> 
> Signed-off-by: dingsenjie <dingsenjie@...ong.com>

You are at least the fourth person who sends this patch[1]. The things I
wrote in reply to the latest submission still applies:

 - the Subject is wrong, it should use a prefix similar to "serial: imx:".

 - I personally like the breaks for clarity.

 - If people agree enough to outvote me, please at least add an empty
   line instead of just removing the break to visually separate the
   cases.

Thanks
Uwe

[1] https://lore.kernel.org/r/20201026125142.21105-1-zhangqilong3@huawei.com
    https://lore.kernel.org/r/20201020130709.28096-1-trix@redhat.com
    https://lore.kernel.org/r/20201107140129.kpfhanzjidvdg662@pengutronix.de

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)