linux-kernel - Re: [PATCH] perf tools: check perf_event_paranoid and kptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Feb 2021 15:38:04 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jackie Liu <jackieliu2113@...il.com>
Cc:     linux-kernel@...r.kernel.org, Jackie Liu <liuyun01@...inos.cn>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [PATCH] perf tools: check perf_event_paranoid and kptr_restrict
 on 'perf top'

On Tue, Feb 23, 2021 at 02:24:40PM +0800, Jackie Liu wrote:
> Perf top will segfault, we should give prompt information like perf
> record instead of crashing directly.
> 
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Jackie Liu <liuyun01@...inos.cn>
> ---
>  tools/perf/builtin-top.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 3673c04d16b6..b257fadba3bd 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -1239,6 +1239,14 @@ static int __cmd_top(struct perf_top *top)
>  			return ret;
>  	}
>  
> +	if (symbol_conf.kptr_restrict && !evlist__exclude_kernel(top->evlist)) {
> +		pr_warning(
> +"Kernel address maps (/proc/{kallsyms,modules}) are restricted.\n\n"
> +"Check /proc/sys/kernel/kptr_restrict and /proc/sys/kernel/perf_event_paranoid.\n\n"
> +"Kernel samples will not be resolved.\n");
> +		return -1;
> +	}
> +

hm, why not fix that crash by checking prog_addrs != NULL before using it

  perf_event__synthesize_one_bpf_prog:
  ...
     __u64 *prog_addrs = (__u64 *)(uintptr_t)(info->jited_ksyms);

it looks like we're already checking on kptr_restrict in
perf_event__process_sample and allow it on some level

jirka

>  	ret = callchain_param__setup_sample_type(&callchain_param);
>  	if (ret)
>  		return ret;
> -- 
> 2.25.1
>