linux-kernel - Re: [PATCH 1/3] power: supply: bq27xxx: fix sign of current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210223154946.1ef58514@aktux>
Date:   Tue, 23 Feb 2021 15:49:46 +0100
From:   Andreas Kemnade <andreas@...nade.info>
To:     Matthias Schiffer <matthias.schiffer@...tq-group.com>
Cc:     Dan Murphy <dmurphy@...com>,
        Pali Rohár <pali@...nel.org>,
        Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] power: supply: bq27xxx: fix sign of current_now for
 newer ICs

On Tue, 23 Feb 2021 15:11:20 +0100
Matthias Schiffer <matthias.schiffer@...tq-group.com> wrote:

> Commit cd060b4d0868 ("power: supply: bq27xxx: fix polarity of current_now")
> changed the sign of current_now for all bq27xxx variants, but on BQ28Z610
> I'm now seeing negated values *with* that patch.
> 
> The GTA04/Openmoko device that was used for testing uses a BQ27000 or
> BQ27010 IC, so I assume only the BQ27XXX_O_ZERO code path was incorrect.
> Revert the behaviour for newer ICs.
> 
> Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now"
> Signed-off-by: Matthias Schiffer <matthias.schiffer@...tq-group.com>
> ---
> 
> @Andreas Kemnade: It would be great to get a confirmation that the
> Openmoko battery indeed uses BQ27000/BQ27010 - I was having some trouble
> finding that information.
> 
I can confirm that.
here is the corresponding schematic:

http://people.openmoko.org/tony_tu/GTA02/hardware/GTA02/CT-GTA02.pdf

Regards,
Andreas