linux-kernel - Re: [PATCH -next] nvmem: Fix return value check in rmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2fff7c82d983baccb91c4a1c0891a9b6cdc50dd6.camel@suse.de>
Date:   Tue, 23 Feb 2021 15:55:29 +0100
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Hulk Robot <hulkci@...wei.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] nvmem: Fix return value check in rmem_read()

On Tue, 2021-02-23 at 14:22 +0000, Wei Yongjun wrote:
> In case of error, the function memremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
> 
> Fixes: 5a3fa75a4d9c ("nvmem: Add driver to expose reserved memory as nvmem")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---

Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>

Thanks!



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)