linux-kernel - Re: [PATCH] Input: st1232 - Fix NORMAL vs. IDLE state handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YDU7x/f4ez5nuFn5@google.com>
Date:   Tue, 23 Feb 2021 09:30:47 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Michael Tretter <m.tretter@...gutronix.de>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Andrej Valek <andrej.valek@...mens.com>,
        linux-input@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: st1232 - Fix NORMAL vs. IDLE state handling

On Tue, Feb 23, 2021 at 11:29:00AM +0100, Michael Tretter wrote:
> On Tue, 23 Feb 2021 10:02:01 +0100, Geert Uytterhoeven wrote:
> > NORMAL (0x0) and IDLE (0x4) are really two different states.  Hence you
> > cannot check for both using a bitmask, as that checks for IDLE only,
> > breaking operation for devices that are in NORMAL state.
> 
> Thanks. I missed that the state is actually a value and not a bitfield.
> 
> > 
> > Fix the wait function to report either state as ready.
> > 
> > Fixes: 6524d8eac258452e ("Input: st1232 - add IDLE state as ready condition")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> Reviewed-by: Michael Tretter <m.tretter@...gutronix.de>

Applied, thank you.

-- 
Dmitry