[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_O3dQvBk5rG+XgQHzguByjMs-Yds71vzj4MG+AMhmyvhw@mail.gmail.com>
Date: Tue, 23 Feb 2021 12:48:03 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: "Deucher, Alexander" <alexander.deucher@....com>,
Dave Airlie <airlied@...ux.ie>,
LKML <linux-kernel@...r.kernel.org>,
Maling list - DRI developers
<dri-devel@...ts.freedesktop.org>,
amd-gfx list <amd-gfx@...ts.freedesktop.org>,
Christian Koenig <christian.koenig@....com>
Subject: Re: [PATCH] drm/amdgpu: Remove unnecessary conversion to bool
On Mon, Feb 22, 2021 at 10:44 PM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:79:40-45: WARNING: conversion
> to bool not needed here.
>
> ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:81:40-45: WARNING: conversion
> to bool not needed here.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/athub_v2_1.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
> index 7b1b183..2ac4988 100644
> --- a/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
> +++ b/drivers/gpu/drm/amd/amdgpu/athub_v2_1.c
> @@ -74,10 +74,8 @@ int athub_v2_1_set_clockgating(struct amdgpu_device *adev,
> case CHIP_SIENNA_CICHLID:
> case CHIP_NAVY_FLOUNDER:
> case CHIP_DIMGREY_CAVEFISH:
> - athub_v2_1_update_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> - athub_v2_1_update_medium_grain_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + athub_v2_1_update_medium_grain_clock_gating(adev, state == AMD_CG_STATE_GATE);
> + athub_v2_1_update_medium_grain_light_sleep(adev, state == AMD_CG_STATE_GATE);
> break;
> default:
> break;
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists