linux-kernel - Re: [PATCH v2 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPf9fhsVFAQ+s+xhmuBFUk0=gVrv45JDRHM=WO9keZZwnA@mail.gmail.com>
Date:   Tue, 23 Feb 2021 20:03:34 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Adrien Grassein <adrien.grassein@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>, catalin.marinas@....com,
        will@...nel.org, DTML <devicetree@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

On Tue, 23 Feb 2021 at 11:45, Adrien Grassein <adrien.grassein@...il.com> wrote:
> > > >
> > > > I would assume this goes from PMIC, so check your schematics. There is
> > > > little point in adding a fixed regulator which is non-controllable.
> > >
> > > No, the 1.8V is issued directly from the alimentation stage.
> > > So we can't control it.
> > >
> > > > I think bindings don't require it.
> > > After reading some code, I can say that vqmmc is not mandatory but it
> > > helped to find out
> > > the caps of the mmc host. In this case, we only support 1.8V on vqmmc.
> > > It avoids driver to guess it (and avoid bad behaviour on any future change).
> >
> > If the supply (hardware) is really 1.8 V then indeed your approach is
> > good. So let's keep that one.
> >
>
> To be sure to understand well: should I keep the fixed regulator?
> Thanks,

Yes, keep it, at least I am fine with it.

Best regards,
Krzysztof