linux-kernel - Re: [PATCH] x86/sgx: Add a basic NUMA allocation scheme to sgx_alloc_epc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDVYnRdxHOME7cNe@kernel.org>
Date:   Tue, 23 Feb 2021 21:33:49 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Dave Hansen <dave.hansen@...el.com>
Cc:     linux-sgx@...r.kernel.org, haitao.huang@...el.com,
        dan.j.williams@...el.com, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/sgx: Add a basic NUMA allocation scheme to
 sgx_alloc_epc_page()

On Tue, Feb 23, 2021 at 11:20:55AM -0800, Dave Hansen wrote:
> On 2/23/21 11:17 AM, Jarkko Sakkinen wrote:
> > Instead, let's just:
> > 
> > 1. Have a global sgx_free_epc_list and remove sgx_epc_section.
> >    Pages from this are allocated from this in LIFO fashion.
> > 2. Instead add struct list_head node_list and use that for node
> >    associated pages.
> > 3. Replace 'int section' with 'int node'.
> 
> I was thinking of something similar.
> 
> I'm fine with this approach.

Here's my two step plan.

1. Let's ack this with the cosmetic changes. It's good first baby
   step to take.
2. I'll do another patch that wipes sgx_epc_section.

Both are functionally self-contained patch that improve. That's why
I don't see point in iterating them as a two patch patch set. One
patch at a time is less overhead.

/Jarkko