linux-kernel - Re: [PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Feb 2021 21:48:32 +0100
From:   Álvaro Fernández Rojas <noltari@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        linux-rpi-kernel@...ts.infradead.org,
        Matt Mackall <mpm@...enic.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "Nícolas F. R. A. Prado" 
        <nfraprado@...tonmail.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-crypto@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-kernel@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        linux-arm-kernel@...ts.infradead.org,
        Scott Branden <sbranden@...adcom.com>,
        Mark Brown <broonie@...nel.org>, Ray Jui <rjui@...adcom.com>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Stefan Wahren <stefan.wahren@...e.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support

Hi Rob,

> El 23 feb 2021, a las 20:34, Rob Herring <robh@...nel.org> escribió:
> 
> On Tue, 23 Feb 2021 18:00:05 +0100, Álvaro Fernández Rojas wrote:
>> Some devices may need to perform a reset before using the RNG, such as the
>> BCM6368.
>> 
>> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
>> ---
>> v3: make resets required if brcm,bcm6368-rng.
>> v2: document reset support.
>> 
>> .../devicetree/bindings/rng/brcm,bcm2835.yaml   | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/brcm,bcm2835.example.dt.yaml: rng@...04180: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml

I don’t get what’s wrong here...

> 
> See https://patchwork.ozlabs.org/patch/1443582
> 
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit.
> 

Best regards,
Álvaro.