linux-kernel - Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1XW0NTFHiEUoLgeHGpKUfYgM8T8Or7ix3m6Fd-TLEn5w@mail.gmail.com>
Date:   Tue, 23 Feb 2021 23:05:45 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Julian Braha <julianbraha@...il.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Zhu Yanjun <zyjzyj2000@...il.com>,
        Doug Ledford <dledford@...hat.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

On Tue, Feb 23, 2021 at 10:54 PM Julian Braha <julianbraha@...il.com> wrote:
> On Tuesday, February 23, 2021 4:26:44 PM EST Arnd Bergmann wrote:
> > On Tue, Feb 23, 2021 at 9:46 PM Julian Braha <julianbraha@...il.com> wrote:
> > >
> > > I have other similar patches that I intend to submit. What should I do,
> > > going forward? Should I use "depends on CRYPTO" for cases like these?
> > > Should I resubmit this patch with that change?
> >
> > No, we should not mix the two methods, that just leads to circular dependencies.
> >
> > How many more patches do you have that need to get merged?
> >
> > If it's only a few, I'd suggest merging them first before we consider a
> > broader change. If the problem is very common, we may want to
> > think about alternative approaches first, and then change everything
> > at once.
>
> Sorry, I don't have a specific number, but it's certainly under a dozen patches.

It's probably best to continue pushing those first then.

        Arnd