linux-kernel - Re: [RFC PATCH] blk-core: remove blk_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210224185521.GA2326119@infradead.org>
Date:   Wed, 24 Feb 2021 18:55:21 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Stefan Hajnoczi <stefanha@...hat.com>,
        Chaitanya Kulkarni <chaitanya.kulkarni@....com>,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        linux-ide@...r.kernel.org, linux-mmc@...r.kernel.org,
        target-devel@...r.kernel.org, linux-nfs@...r.kernel.org,
        linux-block@...r.kernel.org, dm-devel@...hat.com,
        fujita.tomonori@....ntt.co.jp, tim@...erelk.net, mst@...hat.com,
        jasowang@...hat.com, pbonzini@...hat.com, davem@...emloft.net,
        bp@...en8.de, agk@...hat.com, snitzer@...hat.com,
        ulf.hansson@...aro.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, dgilbert@...erlog.com,
        Kai.Makisara@...umbus.fi, alim.akhtar@...sung.com,
        avri.altman@....com, bfields@...ldses.org, chuck.lever@...cle.com,
        baolin.wang@...aro.org, vbadigan@...eaurora.org, zliua@...ron.com,
        richard.peng@...o.com, guoqing.jiang@...ud.ionos.com,
        stanley.chu@...iatek.com, cang@...eaurora.org,
        asutoshd@...eaurora.org, beanhuo@...ron.com, jaegeuk@...nel.org
Subject: Re: [RFC PATCH] blk-core: remove blk_put_request()

On Wed, Feb 24, 2021 at 09:48:21AM -0700, Jens Axboe wrote:
> Would make sense to rename blk_get_request() to blk_mq_alloc_request()
> and then we have API symmetry. The get/put don't make sense when there
> are no references involved.
> 
> But it's a lot of churn for very little reward, which is always kind
> of annoying. Especially for the person that has to carry the patches.

Let's do the following:

 - move the initialize_rq_fn call from blk_get_request into
   blk_mq_alloc_request and make the former a trivial alias for the
   latter
 - migrate to the blk_mq_* versions on a per-driver/subsystem basis.
   The scsi migration depends on the first item above, so it will have
   to go with that or wait for the next merge window
 - don't migrate the legacy ide driver, as it is about to be removed and
   has a huge number of blk_get_request calls