linux-kernel - Re: [PATCH] btrfs: Fixed a brace coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 Feb 2021 20:13:37 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Maheep Kumar Kathuria <me@...eepk.net>
Cc:     clm@...com, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: Fixed a brace coding style issue

On Mon, Feb 15, 2021 at 08:38:20PM +0530, Maheep Kumar Kathuria wrote:
> Fixed a coding style issue in thresh_exec_hook()
> 
> Signed-off-by: Maheep Kumar Kathuria <me@...eepk.net>
> ---
>  fs/btrfs/async-thread.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
> index 309516e6a968..38abeff7af69 100644
> --- a/fs/btrfs/async-thread.c
> +++ b/fs/btrfs/async-thread.c
> @@ -212,9 +212,8 @@ static inline void thresh_exec_hook(struct __btrfs_workqueue *wq)
>  out:
>  	spin_unlock(&wq->thres_lock);
>  
> -	if (need_change) {
> +	if (need_change)
>  		workqueue_set_max_active(wq->normal_wq, wq->current_active);
> -	}

This is really a trivial change, have you checked if there are more?
Fixing them in a larger batch would be better than one by one.