linux-kernel - Re: [PATCH 3/6] firmware: qcom_scm: Workaround lack of "is available" call on SC7180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <161412399088.1254594.11162340495979939098@swboyd.mtv.corp.google.com>
Date:   Tue, 23 Feb 2021 15:46:30 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Jeffrey Hugo <jhugo@...eaurora.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Elliot Berman <eberman@...eaurora.org>,
        Brian Masney <masneyb@...tation.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Douglas Anderson <dianders@...omium.org>
Subject: Re: [PATCH 3/6] firmware: qcom_scm: Workaround lack of "is available" call on SC7180

Quoting Jeffrey Hugo (2021-02-23 15:38:38)
> On 2/23/2021 2:45 PM, Stephen Boyd wrote:
> > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> > index 21e07a464bd9..9ac84b5d6ce0 100644
> > --- a/drivers/firmware/qcom_scm.c
> > +++ b/drivers/firmware/qcom_scm.c
> > @@ -144,6 +145,18 @@ static enum qcom_scm_convention __get_convention(void)
> >       if (!ret && res.result[0] == 1)
> >               goto found;
> >   
> > +     /*
> > +      * Some SC7180 firmwares didn't implement the
> > +      * QCOM_SCM_INFO_IS_CALL_AVAIL call, so we fallback to forcing ARM_64
> > +      * calling conventions on these firmwares. Luckily we don't make any
> > +      * early calls into the firmware on these SoCs so the device pointer
> > +      * will be valid here to check if the compatible matches.
> > +      */
> > +     if (of_device_is_compatible(__scm ? __scm->dev->of_node : NULL, "qcom,scm-sc7180")) {
> > +             forced = true;
> > +             goto found;
> > +     }
> 
> All SC7180 targets run DT?  None have ACPI?
> 

Yes, as far as I know all sc7180 boards are using DT. If they aren't,
then presumably they implemented this QCOM_SCM_INFO_IS_CALL_AVAIL call
so this check is still fine.