linux-kernel - Re: [PATCH] sound/usb generate midi streaming substream names from jack names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hczwpucd3.wl-tiwai@suse.de>
Date:   Wed, 24 Feb 2021 08:57:28 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     George Harker <george@...rge-graphics.co.uk>
Cc:     alsa-devel@...a-project.org, Clemens Ladisch <clemens@...isch.de>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound/usb generate midi streaming substream names from jack names

On Sun, 21 Feb 2021 10:43:32 +0100,
George Harker wrote:
> 
> A number of devices have named substreams which are hard to remember /
> decypher from <device> MIDI n names.  Eg. Korg puts a pass through on
> one substream and iConnectivity devices name the connections.
> 
> This makes it easier to connect to the correct device.  Devices which
> handle naming through quirks are unaffected by this change.
> 
> Addresses TODO comment in sound/usb/midi.c
> 
> Signed-off-by: George Harker <george@...rge-graphics.co.uk>

The code changes look almost OK, but could you try the following?

- Split the patch: one for rewriting with the structs in
  linux/usb/midi.h, another for adding the MIDI device name support

- Try to avoid magic numbers: a few places should be replaced with
  sizeof() or ARRAY_SIZE().


thanks,

Takashi