linux-kernel - Re: [PATCH 5.10 03/29] vdpa_sim: store parsed MAC address in a buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Feb 2021 09:29:54 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Stefano Garzarella <sgarzare@...hat.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jason Wang <jasowang@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>
Subject: Re: [PATCH 5.10 03/29] vdpa_sim: store parsed MAC address in a buffer

Hi!

> >>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> >>@@ -42,6 +42,8 @@ static char *macaddr;
> >> module_param(macaddr, charp, 0);
> >> MODULE_PARM_DESC(macaddr, "Ethernet MAC address");
> >>
> >>+u8 macaddr_buf[ETH_ALEN];
> >>+
> >
> >Should this be static?
> 
> Yes, there is already a patch [1] queued by Michael but not yet upstream.
> When it will be merged upstream I will make sure it will be backported.

Having it in mainline is enough, I don't really think it causes
anything user-visible, so it does not need to be in stable.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)