linux-kernel - Re: [PATCH] hugetlb: document the new location of page subpool pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c34d52f9-1e77-7ed4-2209-df8af9f2e96d@redhat.com>
Date:   Wed, 24 Feb 2021 11:06:39 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Mike Kravetz <mike.kravetz@...cle.com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:     Michal Hocko <mhocko@...e.com>, Oscar Salvador <osalvador@...e.de>,
        Muchun Song <songmuchun@...edance.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] hugetlb: document the new location of page subpool
 pointer

On 24.02.21 05:04, Mike Kravetz wrote:
> Expand comments, no functional change.
> 
> Signed-off-by: Mike Kravetz <mike.kravetz@...cle.com>
> ---
>   include/linux/hugetlb.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index cccd1aab69dd..c0467a7a1fe0 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -476,6 +476,9 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr,
>    * huegtlb page specific state flags.  These flags are located in page.private
>    * of the hugetlb head page.  Functions created via the below macros should be
>    * used to manipulate these flags.
> + * Note: The hugetlb page subpool pointer previously located at page.private
> + * was moved to page[1].private to make room for flags in the head page.  See
> + * hugetlb_page_subpool().
>    *
>    * HPG_restore_reserve - Set when a hugetlb page consumes a reservation at
>    *	allocation time.  Cleared when page is fully instantiated.  Free
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb