lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <70ee14f5-12ee-f33d-a6ea-b890d390d67c@linux.microsoft.com> Date: Tue, 23 Feb 2021 17:57:36 -0800 From: Lakshmi Ramasubramanian <nramas@...ux.microsoft.com> To: Thiago Jung Bauermann <bauerman@...ux.ibm.com> Cc: zohar@...ux.ibm.com, robh@...nel.org, takahiro.akashi@...aro.org, gregkh@...uxfoundation.org, will@...nel.org, joe@...ches.com, catalin.marinas@....com, mpe@...erman.id.au, sfr@...b.auug.org.au, james.morse@....com, sashal@...nel.org, benh@...nel.crashing.org, paulus@...ba.org, frowand.list@...il.com, vincenzo.frascino@....com, mark.rutland@....com, dmitry.kasatkin@...il.com, jmorris@...ei.org, serge@...lyn.com, pasha.tatashin@...een.com, allison@...utok.net, masahiroy@...nel.org, mbrugger@...e.com, hsinyi@...omium.org, tao.li@...o.com, christophe.leroy@....fr, prsriva@...ux.microsoft.com, balajib@...ux.microsoft.com, linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org Subject: Re: [PATCH v19 05/13] of: Add a common kexec FDT setup function On 2/23/21 5:20 PM, Thiago Jung Bauermann wrote: > > Lakshmi Ramasubramanian <nramas@...ux.microsoft.com> writes: > >> From: Rob Herring <robh@...nel.org> >> >> Both arm64 and powerpc do essentially the same FDT /chosen setup for >> kexec. The differences are either omissions that arm64 should have >> or additional properties that will be ignored. The setup code can be >> combined and shared by both powerpc and arm64. >> >> The differences relative to the arm64 version: >> - If /chosen doesn't exist, it will be created (should never happen). >> - Any old dtb and initrd reserved memory will be released. >> - The new initrd and elfcorehdr are marked reserved. >> - "linux,booted-from-kexec" is set. >> >> The differences relative to the powerpc version: >> - "kaslr-seed" and "rng-seed" may be set. >> - "linux,elfcorehdr" is set. >> - Any existing "linux,usable-memory-range" is removed. >> >> Combine the code for setting up the /chosen node in the FDT and updating >> the memory reservation for kexec, for powerpc and arm64, in >> of_kexec_alloc_and_setup_fdt() and move it to "drivers/of/kexec.c". >> >> Signed-off-by: Rob Herring <robh@...nel.org> >> Signed-off-by: Lakshmi Ramasubramanian <nramas@...ux.microsoft.com> >> Fixes: 33488dc4d61f ("of: Add a common kexec FDT setup function") > > A patch cannot fix itself. The world would be a much better place if it > could. :-) :) > >> Reported-by: kernel test robot <lkp@...el.com> >> --- >> drivers/of/Makefile | 6 + >> drivers/of/kexec.c | 265 ++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/of.h | 5 + >> 3 files changed, 276 insertions(+) >> create mode 100644 drivers/of/kexec.c > > With that fixed: > > Reviewed-by: Thiago Jung Bauermann <bauerman@...ux.ibm.com> Thanks for reviewing the patches Thiago. -lakshmi
Powered by blists - more mailing lists